Add wrappers for SDL 2.0.9 rumble functions #824
Conversation
|
Travis seems to fail without the |
|
Weird that we didnt catch that earlier. Can you update the travis file to use 2.0.9 real quick? |
|
Yeah, I'll do that. |
| @@ -3,6 +3,9 @@ when upgrading from a version of rust-sdl2 to another. | |||
|
|
|||
| ### v0.32 | |||
|
|
|||
| [PR #824](https://github.com/Rust-SDL2/rust-sdl2/pull/824): | |||
There was a problem hiding this comment.
For the changelog, technically, 0.32 is already released, so make a new category "v0.32.1 (unreleased)" and put those changes there instead. Otherwise, people will wonder why this rumble feature is not part of 0.32 on crates.io.
Other than than, looks good to me! I tested the update example locally on my computer with a Xbox 360 controller, works really well!
There was a problem hiding this comment.
Yeah, I wasn't so sure about that myself... What you proposed sounds good, I'm gonna do that.
Edit: Oh, and I'm glad it also works fine for you! The 2.0.9 rumble feature really is great, especially with the HIDAPI stuff they added.
Add wrappers for SDL 2.0.9 rumble functions
I added
sdl2::controller::set_rumbleandsdl2::joystick::set_rumble, wrappers for the two new (since SDL 2.0.9) rumble functionsSDL_GameControllerRumbleandSDL_JoystickRumblerespectively.The
game-controllerandjoystickexamples were also extended to test them a little.